Adding a settings validator for coupling #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's easy to set numCoupledIterations > 0 and forget to set looseCoupling: True. - this settings validator checks that and corrects if found.
john-science
approved these changes
Dec 14, 2022
|
This seems like a good use for a settings validator. Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's easy to set numCoupledIterations > 0 and forget to set looseCoupling: True. If you do this, then the coupling scheme will "run" but o.couplingIsActive() will evaluate to false. This can lead to unexpected results.
armi/armi/operators/operator.py
Lines 1061 to 1063 in 359363d
This settings validator aims to remedy this.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.